feat: Improve pdata::otap::testing module and expose it to other crates#2349
Merged
albertlockett merged 3 commits intoopen-telemetry:mainfrom Mar 17, 2026
Merged
feat: Improve pdata::otap::testing module and expose it to other crates#2349albertlockett merged 3 commits intoopen-telemetry:mainfrom
albertlockett merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
========================================
Coverage 87.72% 87.72%
========================================
Files 577 578 +1
Lines 198206 198319 +113
========================================
+ Hits 173873 173974 +101
- Misses 23807 23819 +12
Partials 526 526
🚀 New features to boost your workflow:
|
JakeDern
changed the title
Contributor
Author
|
This is a stacked diff on #2346 and most commits belong to that PR. Will publish this after that goes in |
JakeDern
changed the title
albertlockett
approved these changes
Mar 17, 2026
jmacd
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This is another PR on the path to #2289. During my initial implementation, I realized that a lot of tests were generating invalid otap batches. In order to make that easier, I've updated the logs/metrics/traces macros in the pdata crate to automatically fill in anything required to be spec compliant based on what's been specified. I had a half-baked version of this before, but now that we have the spec we can do this properly.
Additional changes:
Into<OtapArrowRecords>trait bound to OtapBatchStore. From<Logs/Metrics/Traces> was already implemented, it's just useful to have in the bound.testingfeature which lets these be consumed across other crates.What issue does this PR close?
How are these changes tested?
Unit.
Are there any user-facing changes?
No